Skip to content

Add Specification Numbering and build misc. #1574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2021
Merged

Add Specification Numbering and build misc. #1574

merged 1 commit into from
Aug 29, 2021

Conversation

timothystone
Copy link
Contributor

Citing the specification can be cumbersome. Following RFC numbering
formats, the specification is numbered following ISO 2145 at each HEADER
element, e.g., h1, h2, &tc. The numbers are CSS "generated" content
and provide support for the additive focus of the specification.

The paragraph glyph is repositioned absolutely, relative to the header.

The _config.yml is updated to support building. bundle otherwise
failed on Ruby 2.7.x. Updated the exclusions file for IntelliJ.

@timothystone
Copy link
Contributor Author

timothystone commented Jul 31, 2021

Regarding the _config.yml change, I followed the README instructions and found that the site would not build with Ruby 2.3 installed on the Mac. I upgraded to Ruby 2.7 via homebrew—required as the Jekyll markdown gem would not compile—and encountered the same problem. Some research, i.e., SO-fu, found numerous posts regarding the vendor gem path with regards to Jekyll test files.

Adding this line corrected the problem. The move to Ruby 2.7 appears to have generated updates to the map file.

@timothystone
Copy link
Contributor Author

For your convenience... what this looks like running locally is below.

image

Citing the specification can be cumbersome. Following RFC numbering
formats, the specification is numbered following ISO 2145 at each HEADER
 element, e.g., `h1`, `h2`, &tc. The numbers are CSS "generated" content
 and provide support for the additive focus of the specification.

The paragraph glyph is repositioned absolutely, relative to the header.

The `_config.yml` is updated to support building. `bundle` otherwise
failed on Ruby 2.7.x. Updated the exclusions file for IntelliJ.
@timothystone
Copy link
Contributor Author

The PR had incorrectly used the generated CSS file and not Sass.

There is an argument to be made that the generated CSS files should be in the .gitignore file. I had initially edited the generated CSS file.

@dgeb dgeb merged commit a883970 into json-api:gh-pages Aug 29, 2021
@dgeb
Copy link
Member

dgeb commented Aug 29, 2021

Thanks very much @timothystone - this should really help improve referencing the spec!

dgeb added a commit that referenced this pull request Aug 30, 2021
dgeb added a commit that referenced this pull request Aug 30, 2021
@dgeb
Copy link
Member

dgeb commented Aug 30, 2021

I had to revert this in #1579 because the styles were not scoped to only the specification pages. Numbering was shown even on the hero on the home page.

Let me know if you have the bandwidth to create a separate PR that scopes these styles, @timothystone.

@timothystone
Copy link
Contributor Author

timothystone commented Aug 30, 2021

@dgeb On it. I don't recall seeing it on the hero page, but <homer-simpson>D'oh!</homer-simpson>

@dgeb
Copy link
Member

dgeb commented Aug 31, 2021

@timothystone thank you!

dgeb pushed a commit that referenced this pull request Aug 31, 2021
Address oversight of specification numbering scope issue in  #1574.

From the original PR:

Citing the specification can be cumbersome. Following RFC numbering
formats, the specification is numbered following ISO 2145 at each HEADER
element, e.g., `h1`, `h2`, &tc. The numbers are CSS "generated" content
and provide support for the additive focus of the specification.

The paragraph glyph is repositioned absolutely, relative to the header.

The `_config.yml` is updated to support building. bundle otherwise
failed on Ruby 2.7.x. Updated the exclusions file for IntelliJ.

Regarding the `_config.yml` change, I followed the README instructions and
found that the site would not build with Ruby 2.3 installed on the Mac.
I upgraded to Ruby 2.7 via homebrew—required as the Jekyll markdown gem
would not compile—and encountered the same problem. Some research, i.e.,
SO-fu, found numerous posts regarding the vendor gem path with regards to
Jekyll test files.

Adding this line corrected the problem. The move to Ruby 2.7 appears to
have generated updates to the map file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy