Skip to content

Fix inconsitency between general processing rules and pagination links #1606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2022

Conversation

jelhan
Copy link
Contributor

@jelhan jelhan commented Feb 4, 2022

null value was not listed as an allowed value for links in general processing rules for links objects. But it was allowed explicitly for pagination links. This change fixes that inconsitency by allowing null for every link to indicate that it does not exist.

Closes #887

`null` value was not listed as an allowed value for links in general processing rules for links objects. But it was allowed explicitly for pagination links. This change fixes that inconsitency by allowing `null` for _every_ link to indicate that it does not exist.
@jelhan jelhan mentioned this pull request Feb 4, 2022
9 tasks
Copy link

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but not sure if any sentence improvement is needed

Copy link
Member

@dgeb dgeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this inconsistency @jelhan!

@dgeb dgeb merged commit e4b1919 into json-api:gh-pages Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spec contradiction: null as link value
3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy