Skip to content

only client-requested sparse fieldsets are exception to full linkage requirement #1615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

jelhan
Copy link
Contributor

@jelhan jelhan commented Feb 21, 2022

The current wording could be misunderstood that also fields excluded by the server if client does not request a sparse fieldset are an exception for full linkage requirement. This changes clarifies that only exception is if a client explicilty requested a sparse fieldset, which does not include a relationship required for full linkage.

Closes #1614

…requirement

The current wording could be misunderstood that also fields excluded by the server if client does _not_ request a sparse fieldset are an exception for full linkage requirement. This changes clarifies that only exception is if a client _explicilty_ requested a sparse fieldset, which does not include a relationship required for full linkage.
@bradjones1
Copy link
Contributor

I think this does address the question I had in #1614. I might recommend using "specified by" instead of "requested by" the client, or even "specified in the client request"? But I think it's OK as written, too, if you have a strong feeling about it.

@jelhan
Copy link
Contributor Author

jelhan commented Feb 23, 2022

I might recommend using "specified by" instead of "requested by" the client, or even "specified in the client request"? But I think it's OK as written, too, if you have a strong feeling about it.

I don't have strong feelings about. Personally I feel it could be confusing to use the term "specify" in a specification for something else than the specification itself.

But I'm not a native speaker. Will leave this one for editors to decide.

@jelhan jelhan requested a review from dgeb February 23, 2022 10:14
@dgeb
Copy link
Member

dgeb commented Feb 23, 2022

I think this wording is fine. The important clarification here is that the client is in control of the request.

@dgeb dgeb merged commit 0f145e6 into json-api:gh-pages Feb 23, 2022
@auvipy
Copy link

auvipy commented Feb 23, 2022

can we expect a RC 4 soon? it's been 16 months a lot of PR merged in the mean time

Copy link

@jonatanlr98 jonatanlr98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

links": { "self": "http://example.com/posts" }

@jonatanlr98
Copy link

links": { "self": "http://example.com/posts" }

Copy link

@jonatanlr98 jonatanlr98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

links": { "related": { "href": "http://example.com/articles/1/comments", "meta": { "count": 10 } } }

@bradjones1
Copy link
Contributor

@jonatanlr98 This is merged and your comments are without context. Open a new issue or PR if you have issues with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify exception to full linkage requirement and server-initiated sparse fieldsets
5 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy