Applying to add new php library #1619
Conversation
Applying to add new php library: https://github.com/floor9design-ltd/test-data-generator Info: * 100% unit tests * CI implemented * 6 use months in production environments in multiple projects * actively maintained
|
Thanks a lot for opening this PR. I'm sure it's a great library but how is it related to JSON:API specification? I skimmed over the readme and didn't found the specification to be mentioned at all. |
|
Not sure I understand the feedback. Can you help explain? Just to be clear: It's not about the specification - this is a library allowing people to import/export their data to/from JSON API. Note that many others in the list do the same, for example:
If you want to see if I'm referencing the JSON API spec, it's directly linked (along with a validator) in the testing area. |
Are you sure that you included the correct link in the post? It links to
Would be great if you could update the title of this pull request as well to reflect what is it doing. |
|
That's a DIFFERENT repo I'm working on - must have been a copy paste issue! |
|
Corrected repo link in request above. Note that the repo link in the code was correct. |
There was a problem hiding this comment.
Thanks a lot for fixing the link in PR description. To be honest I haven't had a look in the commit before.
Looks good to me. 👍
I don't have merge permissions myself. Need to wait for @dgeb to give it a final review and merge.
Applying to add new php library: https://github.com/floor9design-ltd/json-api-formatter
Info: