drop constraints on attribute values #1630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgeb
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops any constraints on attribute values as proposed in #1553. Most noticeable the requirement hat an object used as attribute value (even if nested) must not have a key
linksorrelationships.There is no need anymore to restrict these for future usage in the specification itself. All potential use cases could be solved by using
linksorrelationshipsmembers of the JSON:API resource object. Or by an extension registering additional members on the JSON:API resource object.Dropping this requirement simplifies the teaching of JSON:API. We could state that the JSON:API specification is agnostic about attribute values, which wasn't true before.
I will create a complementary merge request to drop the requirement to ignore keys starting with
@in objects used as attribute values as proposed in #1367 and #1584. It is closely related to this one. But I feel that it is easier to discuss them separately. Especially if there are discussion needs in regards to JSON-LD.