Skip to content

Fix the Gemfile to work with Ruby 3.x #1782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2024
Merged

Fix the Gemfile to work with Ruby 3.x #1782

merged 1 commit into from
Dec 19, 2024

Conversation

kurtmckee
Copy link
Contributor

@kurtmckee kurtmckee commented Dec 11, 2024 •
edited
Loading

It may be that this will resolve the following failure in CD (recent example):

 [!] 
There was an error parsing `Gemfile`: uninitialized constant Bundler::Dsl::SocketError. Bundler cannot continue.

 #  from /github/workspace/Gemfile:9
 #  -------------------------------------------
 #      JSON.parse(open('https://pages.github.com/versions.json').read)
 >    rescue SocketError
 #      { 'github-pages' => 67 }
 #  -------------------------------------------

Warning: The github-pages gem can't satisfy your Gemfile's dependencies.

This has been tested locally, and on Ruby 3.3.6 it allows the commands documented in the README to succeed.

Closes #1778

@jelhan
Copy link
Contributor

jelhan commented Dec 19, 2024

Thanks a lot for following up on this.

Good catch that the CI pipeline reports an error as well. But it seems that the build and deployment to GitHub Pages weren't broken to it. I can see the changes done in 24feb81 on jsonapi.org.

@jelhan jelhan merged commit 31748ad into json-api:gh-pages Dec 19, 2024
1 check passed
@kurtmckee kurtmckee deleted the ruby-3-issue-1778 branch December 19, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dev setup instructions don't work for me
2 participants
@kurtmckee @jelhan
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy