convert non-normative note into constraint #434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63f31d3 to
1e5ca6e
Compare
|
👍 |
f5b7a6d to
734f942
Compare
This non-normative note included RFC2119 keywords, making its status as a note ambiguous. Per our previous discussion, json-api should not disallow implementors from including hasOne fkeys as attributes, but it should require that any relations which are provided must be represented under the links object.
tkellen
pushed a commit
that referenced
this pull request
Mar 8, 2015
convert non-normative note into constraint
|
@tkellen There's one occurrence of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This non-normative note included RFC2119 keywords, making its
status as a note ambiguous. Per our previous discussion, json-api
should not disallow implementors from including hasOne fkeys as
attributes, but it should require that any relations which are
provided must be represented under the links object.