-
Notifications
You must be signed in to change notification settings - Fork 890
Introduce "resource identifier objects" #632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
228cbec
to
c9dc099
Compare
The body of the request **MUST** contain a `data` member whose value is an | ||
an array of objects that each contain a `type` and `id`. | ||
The body of the request **MUST** contain a `"data"` member whose value is an | ||
an array of resource identifier objects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would link this to the resource identifier objects section (same for all references).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed - might as well add these references now.
👍 with those minor nits addressed. I'm okay with waiting on the inter-document linking, if you think it'll be too arduous given our current timeframe. |
Instead of referring to "linkage objects" that identify resources with `type` and `id`, this concept is generalized with a new definition: "resource identifier objects". Using this term throughout the spec provides simplification and consistency, as it can be used not only for relationships but also for bulk deletes. Furthermore, with the introduction of the relationships object, we no longer need to force the term "linkage" into the document structure. Within a relationships object, this member has been replaced simply with `"data"`, which represents the relationship data. This has a nice parallel for relationship URLs in which relationship data _is_ the primary data.
@tkellen Thanks for the review. I just made all those changes with the exception of the inter-document links. We'll need a thorough review to catch all of those. Plus I'm not sure if there's a better strategy than just hard-coding the URLs in each document. |
👍 |
Introduce "resource identifier objects"
+1. Thanks for actually writing this up, @dgeb. My family's in town today and tomorrow and I'm graduating, so I didn't have a chance to do this. |
Wow, congratulations @ethanresnick! Hopefully our little spec will graduate along with you :) |
Thanks @dgeb! It's been quite a crazy day. |
@ethanresnick for someone crazy day only begins 😉 |
Instead of referring to "linkage objects" that identify resources with
type
andid
, this concept is generalized with a new definition:"resource identifier objects".
Using this term throughout the spec provides simplification and
consistency, as it can be used not only for relationships but also
for bulk deletes.
Furthermore, with the introduction of the relationships object, we no
longer need to force the term "linkage" into the document structure.
Within a relationships object, this member has been replaced simply with
"data"
, which represents the relationship data. This has a niceparallel for relationship URLs in which relationship data is the
primary data.
Credit to @ethanresnick for the term "resource identifier object".
See #618 and #625 for more history and discussion.