This repository was archived by the owner on Nov 13, 2020. It is now read-only.
Make API work when used as a gem #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,7 +18,7 @@ Gem::Specification.new do |spec| | |||
| spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) | |||
| spec.require_paths = ["lib"] | |||
|
|
|||
| spec.add_development_dependency "json-schema" | |||
| spec.add_dependency "json-schema" | |||
steveklabnik
added a commit
that referenced
this pull request
Dec 12, 2013
Make API work when used as a gem
|
Thank you! This is what I get for just banging out some code late at night when I'm tired. ;) |
|
I pushed out a 0.1.1 that includes this fix. Thanks again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of issues that came up when I used this as a gem in another project. These are just some proposed fixes-- in particular the relative path doesn't seem to work with the validator as it uses the containing project as the base path instead of the gem itself.