-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Feat: New website #6286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat: New website #6286
Conversation
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com>
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Welcome @thisisobate! It looks like this is your first PR to knative/docs 🎉 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: thisisobate The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com>
@Leo6Leo: GitHub didn't allow me to request PR reviews from the following users: ankitajana21. Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Nevermind...was able to recreate now. Will push a fix right away |
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Where exactly are you referring to? The cards? Tried reproducing on firefox but no success. What version of firefox are you running? @evankanderson |
I don't like the grey card backgrounds, but I see them on phone. (Maybe my desktop is having the issue, but things look cleaner without the grey) |
what do you suggest we do? change the background color of the cards to something lighter? Going this direction would mean updating other cards across the homepage to maintain consistency |
Can the cards match the background, with a small drop shadow if needed?
…On Wed, Jul 30, 2025, 1:02 PM Uchechukwu Obasi ***@***.***> wrote:
*thisisobate* left a comment (knative/docs#6286)
<#6286 (comment)>
what do you suggest we do? change the background color of the cards to
something lighter?
—
Reply to this email directly, view it on GitHub
<#6286 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB4XENZBVS2Y3KF4TVVASS33LEQD3AVCNFSM6AAAAACAW2XMOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCMZXGY2TEOJUGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Signed-off-by: thisisobate <obasiuche62@gmail.com>
…con as spiral Signed-off-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Todo
Fixes #6277