Skip to content

Cherry pick form handling fix from 3.8.x #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 10, 2018
Merged

Cherry pick form handling fix from 3.8.x #2

merged 2 commits into from
Oct 10, 2018

Conversation

hamishcampbell
Copy link

Refer encode#5800

@hamishcampbell
Fix request formdata handling (encode#5800)
64d288e 
* Rename 'wsgi' request test to more accurate 'http'

* Test duplicate request stream parsing

* Fix setting post/files on the underlying request
@hamishcampbell hamishcampbell requested a review from craigds October 9, 2018 01:43
craigds
craigds approved these changes Oct 10, 2018
View reviewed changes
Copy link
Member

@craigds craigds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay. do all the tests pass? two of them didn't exist in 3.6.x

@hamishcampbell
Copy link
Author

Yeah, those tests pass, although there are other test failures that would seem to be unrelated (they already fail in kx-3.6.x):

========================================== FAILURES ===========================================
__________________ SessionAuthTests.test_post_form_session_auth_failing_csrf __________________
tests/test_authentication.py:204: in test_post_form_session_auth_failing_csrf
    assert response.status_code == status.HTTP_403_FORBIDDEN
E   AssertionError: assert 200 == 403
E    +  where 200 = <HttpResponse status_code=200, "text/html; charset=utf-8">.status_code
E    +  and   403 = status.HTTP_403_FORBIDDEN
____________________ TestAPITestClient.test_explicitly_enforce_csrf_checks ____________________
tests/test_testing.py:121: in test_explicitly_enforce_csrf_checks
    assert response.status_code == 403
E   AssertionError: assert 200 == 403
E    +  where 200 = <Response status_code=200, "application/json">.status_code
__________________ TestAPIRequestFactory.test_explicitly_enforce_csrf_checks __________________
tests/test_testing.py:229: in test_explicitly_enforce_csrf_checks
    assert response.status_code == 403
E   AssertionError: assert 200 == 403
E    +  where 200 = <Response status_code=200, "text/html; charset=utf-8">.status_code
====================== 3 failed, 1093 passed, 1 skipped in 9.56 seconds =======================

@hamishcampbell hamishcampbell merged commit feb1522 into kx-3.6.x Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigds craigds craigds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamishcampbell @craigds
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy