laravel-workflow · rmcdaniel · Jan 30, 2024 · Jan 29, 2024 · Jan 30, 2024 · Jan 30, 2024
diff --git a/src/Activity.php b/src/Activity.php
@@ -58,6 +58,8 @@ public function __construct(
         if (property_exists($this, 'queue')) {
             $this->onQueue($this->queue);
         }
+
+        $this->afterCommit = true;
     }
 
     public function backoff()

diff --git a/src/Workflow.php b/src/Workflow.php
@@ -65,6 +65,8 @@ public function __construct(
         if (property_exists($this, 'queue')) {
             $this->onQueue($this->queue);
         }
+
+        $this->afterCommit = true;
     }
 
     public function query($method)

diff --git a/tests/Feature/DispatchWorkflowInTransactionTest.php b/tests/Feature/DispatchWorkflowInTransactionTest.php
@@ -0,0 +1,51 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Feature;
+
+use Illuminate\Support\Facades\DB;
+use Tests\Fixtures\TestSimpleWorkflow;
+use Tests\TestCase;
+use Workflow\States\WorkflowCompletedStatus;
+use Workflow\WorkflowStub;
+
+final class DispatchWorkflowInTransactionTest extends TestCase
+{
+    public function testRaceCondition(): void
+    {
+        $workflow = null;
+        $start = now();
+
+        DB::transaction(static function () use (&$workflow) {
+            $workflow = WorkflowStub::make(TestSimpleWorkflow::class);
+
+            /**
+             * use case: link the workflow to an entity in the database
+             *
+             * EntityWorkflow::create(["entity_id" => 1, "workflow_id" => $workflow->id()])
+             */
+
+            /**
+             * dispatch the workflow to the queue
+             */
+            $workflow->start();
+
+            /**
+             * pretend that committing the transaction takes a while
+             */
+            sleep(3);
+        });
+
+        /**
+         * the workflow stays in the pending state as the transaction was not committed
+         * when the worker was told to process the workflow
+         *
+         * the exception is silently caught in src/Workflow.php:115
+         */
+        while ($workflow->running() && $workflow->exceptions()->isEmpty() && now()->diffInSeconds($start) < 15);
+
+        $this->assertSame(WorkflowCompletedStatus::class, $workflow->status());
+        $this->assertEmpty($workflow->exceptions());
+    }
+}
diff --git a/tests/Fixtures/TestSimpleWorkflow.php b/tests/Fixtures/TestSimpleWorkflow.php
@@ -0,0 +1,22 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Fixtures;
+
+use Workflow\ActivityStub;
+use Workflow\Workflow;
+
+class TestSimpleWorkflow extends Workflow
+{
+    public $connection = 'redis';
+
+    public $queue = 'default';
+
+    public function execute()
+    {
+        $result = yield ActivityStub::make(TestActivity::class);
+
+        return 'workflow_' . $result;
+    }
+}