Skip to content

Added workflowId to ActivityCompleted and ActivityFailed #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jbardnz
Copy link
Contributor

@jbardnz jbardnz commented Jan 31, 2024

fix #159

@rmcdaniel
Copy link
Contributor

If you run composer ecs locally, it will fix that issue for you.

@rmcdaniel
Copy link
Contributor

Sorry about that. Also you might hit a broken test after that passes.

$event = new ActivityCompleted($activityId, 'output', 'time');

Let me know if it gets to be too much of a pain!

@rmcdaniel
Copy link
Contributor

You can run the feature tests locally by using any driver other than the sync driver and running composer feature. You can run the unit tests by using the sync driver and running composer unit.

@rmcdaniel rmcdaniel merged commit 71a8694 into laravel-workflow:master Jan 31, 2024
@rmcdaniel
Copy link
Contributor

Awesome! Thanks!

@jbardnz jbardnz deleted the workflow-id-activity-events branch January 31, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any reason why the ActivityCompleted and ActivityFailed events don't include the workflowId?
2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy