Update HTTP dependencies and reject chunked requests #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve support for legacy HTTP servers, improve close detection and properly reject plain HTTP requests using
Transfer-Encoding: chunked. The latter only affects rare incoming chunked requests over plaintext HTTP, it does not affect common chunked response messages or requests sent over HTTP CONNECT or SOCKS. Handling these rare requests would either involve buffering the incoming request message or re-encoding on the fly once reactphp/http-client#38 is in.Builds on top of #49
Refs reactphp/http#316, reactphp/http#318 and reactphp/http-client#130