Skip to content

jxl: remove support for never-implemented JXL_TYPE_UINT32 #2813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2022

Conversation

lovell
Copy link
Member

@lovell lovell commented May 20, 2022

This was removed via libjxl/libjxl#1337

Technically it has been deprecated, but can be considered as good as gone due to not being included in the official spec.

@lovell
Copy link
Member Author

lovell commented May 20, 2022

Whilst clang reports a warning, gcc cannot compile libvips against the latest main branch of libjxl without the change in this PR, so we might want to backport this to 8.12 if there are going to be further 8.12.x releases.

clang:

../libvips/foreign/jxlsave.c:284:27: warning: 'JXL_TYPE_UINT32' is deprecated [-Wdeprecated-declarations]
                jxl->format.data_type = JXL_TYPE_UINT32;

gcc:

../libvips/foreign/jxlsave.c:185:2: error: case label does not reduce to an integer constant
  185 |  case JXL_TYPE_UINT32:
      |  ^~~~

@jcupitt jcupitt merged commit 7d4cba1 into libvips:master May 21, 2022
@jcupitt
Copy link
Member

jcupitt commented May 21, 2022

argh, why did they remove the enum and break all downstream projects? Sure, I'll patch 8.12 too.

jcupitt added a commit that referenced this pull request May 21, 2022
note in changelog

see #2813
@lovell lovell deleted the jxl-remove-unsupported-formats branch May 21, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy