Skip to content

dzsave: IIIF: use named region of 'full' when no crop takes place #4578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2025

Conversation

lovell
Copy link
Member

@lovell lovell commented Jun 23, 2025

Will improve compliance with IIIF v2 and v3, the specs of which both mandate support for the "full" region.

I've checked OpenLayers and OpenSeadragon and they both contain the same logic so it should address most of #2036

This PR only handles the "region" part of the URL and doesn't touch the "size" as (I think) as long as the tile size is smaller than the original image size in either (or both) dimensions then a "max" tile will not be requested. If the tile size is larger than the original image in both dimensions then there's only one tile/layer, so you don't really need dzsave.

I've also added a couple of initial, basic IIIF layout tests as there were none. I used the sample dimensions from #4576 for these as it should be fixed too.

Should improve conformance with IIIF v2 and v3, the specs of
which both mandate support for the 'full' region.

Also adds a couple of initial, basic IIIF layout tests
@lovell lovell force-pushed the 8.17-dzsave-iiif-full branch from 411255d to a932370 Compare July 4, 2025 15:12
@jcupitt
Copy link
Member

jcupitt commented Jul 5, 2025

Hi @lovell, I'm so confused :( I thought full meant the full size image, not the first shrink to fit inside a single tile.

If it just means a one-tile version of the image (a tile that contains the full image I guess?) then I agree, this is a very simple fix. Phew!

@jcupitt jcupitt merged commit 2e78894 into libvips:8.17 Jul 6, 2025
6 checks passed
@lovell
Copy link
Member Author

lovell commented Jul 6, 2025

Yes, I think the confusion stems from IIIFv2 using the concept of "full" to represent both "region" and "size" but with different meanings. IIIFv3 fixes the naming things is hard problem for "size" by replacing "full" with "max".

The discussion about this will be celebrating its 10th birthday later this year - see IIIF/api#620

@lovell lovell deleted the 8.17-dzsave-iiif-full branch July 6, 2025 19:08
@jcupitt
Copy link
Member

jcupitt commented Jul 6, 2025

Yes, I think the confusion stems from IIIFv2 using the concept of "full" to represent both "region" and "size" but with different meanings.

Yare yare, as jojo says 🙄

@jcupitt jcupitt mentioned this pull request Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy