Update ChangeLog ahead of v8.17.1 #4603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, I'd like to get #4599 in too. We could merge it, then quickly do a follow-up PR to fix any shortcomings. Does that sound OK? |
|
Let's give zhifengzhuang until the end of the day on Monday, but then just go ahead and merge, with a follow-up PR for review comments. |
|
You're right. Let's wait for PR #4599 to land first. |
234f9ef to
522359e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's time for a formal patch release.
We might also consider including a variant of PR #4599 in v8.17.1, although I think most users are already using the latest PDFium releases, i.e. similar to our approach in OSS-Fuzz:
https://github.com/google/oss-fuzz/blob/76d5d6351e09fc2a9da9e057001cd5daecb1b6a2/projects/libvips/Dockerfile#L37