Add multi arch support to mod builder via optional MULTI_ARCH workflow var
#46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 24, 2024
thespad
reviewed
Feb 14, 2024
thespad
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested a bunch of scenarios with my local test repo: https://github.com/aptalca/test/actions
Packages pushed to https://github.com/users/aptalca/packages/container/package/mods
For commit pushes, it first generates a list of tags, then iterates over the list when tagging, pushing and generating the manifests.
For PR pushes, since there is only one tag, no list is used.
Example PR for a multi-arch mod: linuxserver/docker-mods#822
Once this is merged, the remplate update PR can be merged: linuxserver/docker-mods#823