[Flang] Force lowering to Complex for AMDGPU #144927
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid libm when targeting AMDGPU as those symbols are not available on the device and we rely on MLIR complex operations to later map to OCML calls.
There was a problem hiding this comment.
Pull Request Overview
This PR implements a change to avoid using libm when targeting AMDGPU by forcing lowering to complex operations which later map to OCML calls.
- Add a new check to detect AMDGPU targets using fir::getTargetTriple().isAMDGCN().
- Bypass the invocation of the libm call when AMDGPU is detected.
Comments suppressed due to low confidence (1)
flang/lib/Optimizer/Builder/IntrinsicCall.cpp:1234
- [nitpick] Consider adding unit tests to validate the AMDGPU branch, ensuring that libm is correctly bypassed when targeting AMDGPU.
bool isAMDGPU = fir::getTargetTriple(builder.getModule()).isAMDGCN();
|
@llvm/pr-subscribers-flang-fir-hlfir Author: Akash Banerjee (TIFitis) ChangesAvoid libm when targeting AMDGPU as those symbols are not available on the device and we rely on MLIR complex operations to later map to OCML calls. PRs #144924 & #144926 add additional related support. Full diff: https://github.com/llvm/llvm-project/pull/144927.diff 1 Files Affected:
diff --git a/flang/lib/Optimizer/Builder/IntrinsicCall.cpp b/flang/lib/Optimizer/Builder/IntrinsicCall.cpp
index 178b6770d6b53..2ca7f2784aab3 100644
--- a/flang/lib/Optimizer/Builder/IntrinsicCall.cpp
+++ b/flang/lib/Optimizer/Builder/IntrinsicCall.cpp
@@ -1228,8 +1228,11 @@ mlir::Value genComplexMathOp(fir::FirOpBuilder &builder, mlir::Location loc,
llvm::StringRef mathLibFuncName = mathOp.runtimeFunc;
if (!mathLibFuncName.empty()) {
// If we enabled MLIR complex or can use approximate operations, we should
- // NOT use libm.
- if (!forceMlirComplex && !canUseApprox) {
+ // NOT use libm. Avoid libm when targeting AMDGPU as those symbols are not
+ // available on the device and we rely on MLIR complex operations to
+ // later map to OCML calls.
+ bool isAMDGPU = fir::getTargetTriple(builder.getModule()).isAMDGCN();
+ if (!forceMlirComplex && !canUseApprox && !isAMDGPU) {
result = genLibCall(builder, loc, mathOp, mathLibFuncType, args);
LLVM_DEBUG(result.dump(); llvm::dbgs() << "\n");
return result;
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid libm when targeting AMDGPU as those symbols are not available on the device and we rely on MLIR complex operations to later map to OCML calls.
PRs #144924 & #144926 add additional related support.