Skip to content

Stop pushing empty release commit for community #12880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

silv-io
Copy link
Member

@silv-io silv-io commented Jul 21, 2025

Motivation

With the removal of CircleCI and #12829 we removed the need of having an empty commit to trigger the CI on releases of localstack-core and localstack/localstack.

We can now proceed to trigger the pipeline purely via the tag on the latest commit in the main branch.

Changes

  • remove --allow-empty in the release commit

Testing

  • running git commit -m "test" on a clean working tree just skips the creation of a commit. Subsequently running git tag will then put it on the latest commit in the branch.

TODO

What's left to do:

  • Decide whether we should remove --allow-empty for the development iteration branch as well or not. In theory this commit is also unnecessary
    • The empty commit after the release is necessary for getting out a dev release for localstack-pro to depend on.
    • However, if we manage to remove this dependency on dev versions we can remove this empty commit as well
  • ...

@silv-io silv-io marked this pull request as ready for review July 21, 2025 14:59
@silv-io silv-io requested review from thrau and alexrashed as code owners July 21, 2025 14:59
@silv-io silv-io added the semver: patch Non-breaking changes which can be included in patch releases label Jul 21, 2025
Copy link

github-actions bot commented Jul 21, 2025

Test Results - Preflight, Unit

21 983 tests  ±0   20 249 ✅ ±0   6m 32s ⏱️ +14s
     1 suites ±0    1 734 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit f545a3a. ± Comparison against base commit 36014d4.

♻️ This comment has been updated with latest results.

Copy link

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 10s ⏱️ +4s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit f545a3a. ± Comparison against base commit 36014d4.

Copy link

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 21m 16s ⏱️
5 288 tests 4 356 ✅ 931 💤 1 ❌
5 294 runs  4 356 ✅ 937 💤 1 ❌

For more details on these failures, see this check.

Results for commit f545a3a.

Copy link

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 46m 1s ⏱️ +16s
4 929 tests ±0  4 151 ✅ ±0  778 💤 ±0  0 ❌ ±0 
4 931 runs  ±0  4 151 ✅ ±0  780 💤 ±0  0 ❌ ±0 

Results for commit f545a3a. ± Comparison against base commit 36014d4.

@alexrashed alexrashed marked this pull request as draft July 22, 2025 07:33
@alexrashed alexrashed added this to the 4.8 milestone Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy