-
-
Notifications
You must be signed in to change notification settings - Fork 1
fix: Windows support-exit 0
instead of true
in scripts
#171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Windows support-exit 0
instead of true
in scripts
#171
Conversation
Hello, @vadimpiven Thank you for submitting the issue and PR! I’ll review this bug within the next 24 hours, so I kindly ask for your patience until then :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #171 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 416 416
=========================================
Hits 416 416 Continue to review full report in Codecov by Sentry.
|
BTW, I found the |
exit 0
instead of true
in scripts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vadimpiven Thanks for the PR! It looks good to me.
I've reviewed it and confirmed that it is indeed a bug. The issue can be reproduced when using PowerShell or CMD.
The new version, v1.2.4
, will be published within the next hour.
but not windows-arm64 which would also be highly appreciated
I previously attempted to support Windows-arm64 (Tier 2 in Node.js), but ran into limitations as neither the Docker image nor the GitHub Actions runner image support Windows-arm64. Unfortunately, this means it cannot currently be supported.
If you have any alternative ideas for enabling Windows-arm64 support, please feel free to open an issue. I'd be happy to review it!
Thanks a lot! |
@vadimpiven 👍👍 Just a note: If it can't be built through GitHub Actions CI, it won't be acceptable. Additionally, I tried using the assets built by LLVM (link), but since they can't guarantee stability(sometimes the binaries are missing) and security, they are also not acceptable! |
Support running
git-clang-format
on windows machines.Summary
I am using Angular clang-format for formatting my C++ code used to build Node.js Native Addon. I want to support arm64 targets, and Angular clang-format only supports amd64 ones. I wanted to adopt
git-clang-format
in place of it as it bundles linux-arm64 and darwin-arm64 binaries (but not windows-arm64 which would also be highly appreciated).I tried the following:
clang-format-git
as dev dependencynpm i
on windows machineAnd got an error:
Details
The error originates from
postinstall
scripts, mainly from tail command|| true
. The error reproduces in both CMD and PowerShell. Currentpostinstall
script runs successfully only in git-bash and WSL. But in my case I have to runnpm i
from Visual Studio Developer Console which is either CMD or PowerShell.To fix the error
|| exit 0
could be used in place of|| true
as a windows-compatible alternative.BTW I would highly appreciate if new version would be published to the npm registry after this change is merged, so I would be able to use this package :)
How did you test this change?
After the change I was able to successfully use package both from PowerShell and WSL.
Resolved Issues
Closes #170