Skip to content

chore: bump ESLint from v8 to v9 #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Conversation

lumirlumir
Copy link
Owner

@lumirlumir lumirlumir commented Jan 16, 2025

This pull request includes several changes to the ESLint configuration and various code files to update dependencies and improve code quality. The most important changes include the removal of old ESLint configurations, updating the ESLint configuration to use a new package, and making minor adjustments to code files to align with the updated ESLint rules.

ESLint Configuration Updates:

  • Removed old ESLint configuration files .eslintignore and .eslintrc.js and updated the .github/sync-client.yml to reflect these changes. [1] [2] [3] [4]
  • Added a new ESLint configuration file eslint.config.js that uses the eslint-config-bananass package.

Dependency Updates:

  • Updated package.json to use the new ESLint package eslint-config-bananass and removed old ESLint-related dependencies.

Code Adjustments:

  • Added /* eslint-disable n/prefer-node-protocol */ comments to various files to comply with the new ESLint rules. [1] [2] [3] [4] [5] [6] [7] [8]
  • Removed inline ESLint disable comments for no-console in multiple files to align with the updated ESLint rules. [1] [2] [3] [4]

These changes collectively improve the codebase by standardizing the ESLint configuration and ensuring compliance with updated linting rules.

@github-actions github-actions bot added the 🏷️ type: chore Auto-generated label based on Conventional Commits specification for GitHub release notes label Jan 16, 2025
Copy link

Labels have been automatically applied based on the conventional commit types.🏷️

@lumirlumir lumirlumir merged commit 9943700 into main Jan 16, 2025
31 checks passed
@lumirlumir lumirlumir deleted the chore-bump-eslint-from-v8-to-v9 branch January 16, 2025 14:49
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7263bd1) to head (55f43b3).
Report is 2 commits behind head on main.

@@            Coverage Diff            @@
##              main      #174   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          416       429   +13     
=========================================
+ Hits           416       429   +13     
Files with missing lines Coverage Δ
packages/clang-format-git-python/src/cli.js 100.00% <100.00%> (ø)
...-format-git-python/src/utils/gitClangFormatPath.js 100.00% <100.00%> (ø)
packages/clang-format-git/src/cli.js 100.00% <100.00%> (ø)
...lang-format-git/src/utils/getGitClangFormatPath.js 100.00% <100.00%> (ø)
...s/clang-format-git/src/utils/gitClangFormatPath.js 100.00% <100.00%> (ø)
packages/clang-format-node/src/cli.js 100.00% <100.00%> (ø)
...ges/clang-format-node/src/utils/clangFormatPath.js 100.00% <100.00%> (ø)
.../clang-format-node/src/utils/getClangFormatPath.js 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7263bd1...55f43b3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ type: chore Auto-generated label based on Conventional Commits specification for GitHub release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy