Skip to content

chore(website): conditionally enable bundle analysis in Codecov Vite plugin #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lumirlumir
Copy link
Owner

@lumirlumir lumirlumir commented Mar 10, 2025

This pull request includes changes to the website/.vitepress/config.mjs and website/package.json files to improve the configuration and dependency management for the project. The most important changes include the addition of the is-interactive package and adjustments to the Codecov plugin configuration to work better in CI environments.

Dependency management and configuration improvements:

@Copilot Copilot AI review requested due to automatic review settings March 10, 2025 08:58
Copy link

vercel bot commented Mar 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
npm-clang-format-node-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 9:16am

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR conditionally enables bundle analysis in the Codecov Vite plugin based on the presence of the CODECOV_TOKEN environment variable.

  • Changed the enableBundleAnalysis configuration from hardcoded true to a conditional check.
  • Updates the Codecov Vite plugin configuration to reflect the environment variable's presence.

Reviewed Changes

File Description
website/.vitepress/config.mjs Sets enableBundleAnalysis based on process.env.CODECOV_TOKEN.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

website/.vitepress/config.mjs:341

  • [nitpick] Consider whether checking for undefined is sufficient: if CODECOV_TOKEN is an empty string, the condition will evaluate to true. If the intent is to require a non-empty token, you might use Boolean(process.env.CODECOV_TOKEN) instead.
enableBundleAnalysis: process.env.CODECOV_TOKEN !== undefined,

@github-actions github-actions bot added 🏷️ scope: website Auto-generated label based on Conventional Commits specification for GitHub release notes 🏷️ type: chore Auto-generated label based on Conventional Commits specification for GitHub release notes labels Mar 10, 2025
Copy link

Labels have been automatically applied based on the Conventional Commits specification.🏷️

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bd558b0) to head (5eb1e97).
Report is 1 commits behind head on main.

@@            Coverage Diff            @@
##              main      #267   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          439       439           
=========================================
  Hits           439       439           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd558b0...5eb1e97. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lumirlumir lumirlumir closed this Mar 10, 2025
@lumirlumir lumirlumir deleted the chore-website-conditionally-enable-bundle-analysis-in-codecov-vite-plugin branch March 10, 2025 09:05
@lumirlumir lumirlumir restored the chore-website-conditionally-enable-bundle-analysis-in-codecov-vite-plugin branch March 10, 2025 09:10
@lumirlumir lumirlumir reopened this Mar 10, 2025
Copy link

codecov bot commented Mar 10, 2025

Bundle Report

Bundle size has no change ✅

@lumirlumir lumirlumir requested a review from Copilot March 10, 2025 09:20
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR adjusts the Codecov Vite plugin configuration to conditionally enable bundle analysis only in CI environments. Key changes include:

  • Importing the "is-interactive" package in the Vitepress configuration.
  • Updating the Codecov plugin configuration to use !isInteractive(), ensuring bundle analysis runs only in CI.
  • Adding "is-interactive" as a development dependency in package.json.

Reviewed Changes

File Description
website/.vitepress/config.mjs Updated the Codecov Vite plugin configuration for conditional bundle analysis in CI.
website/package.json Added "is-interactive" as a development dependency to support CI detection.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

@lumirlumir lumirlumir merged commit 0aaa2a0 into main Mar 10, 2025
43 checks passed
@lumirlumir lumirlumir deleted the chore-website-conditionally-enable-bundle-analysis-in-codecov-vite-plugin branch March 10, 2025 09:23
lumirlumir added a commit that referenced this pull request Apr 2, 2025
…ch`) (#297)

## Release Information: `v1.3.3`

New release of `lumirlumir/npm-clang-format-node` has arrived! 🎉

This PR bumps the package versions from `v1.3.2` to `v1.3.3` (`patch`).

See
[Actions](https://github.com/lumirlumir/npm-clang-format-node/actions/runs/14215733817)
for more details.

| Info        | Value                      |
| ----------- | -------------------------- |
| Repository  | `lumirlumir/npm-clang-format-node` |
| SEMVER      | `patch`     |
| Pre ID      | `canary`      |
| Short SHA   | ed550b4       |
| Old Version | `v1.3.2`  |
| New Version | `v1.3.3`  |

<!-- Release notes generated using configuration in .github/release.yml
at main -->

## What's Changed
### 🧰 Chores
* chore(sync-server): update `lint-staged.config.js` by @lumirlumir in
#259
* chore(sync-server): update `.editorconfig` `max_line_length` to
`100000` by @lumirlumir in
#260
* chore(website): add Codecov Vite plugin and update related configs for
bundle analyzing by @lumirlumir in
#266
* chore(website): conditionally enable bundle analysis in Codecov Vite
plugin by @lumirlumir in
#267
* chore(sync-server): update `.markdownlint.json` by @lumirlumir in
#272
* chore(sync-server): update ESLint config and lint-staged to support
markdown linting by @lumirlumir in
#275
* chore(sync-server): update `FUNDING.yml` by @lumirlumir in
#285
* chore(website): update `package.json` and rename `.mjs` to `.js` by
@lumirlumir in
#286
* chore(sync-server): update root level configuration files and fix
typos by @lumirlumir in
#293
* chore(*): update `tsconfig.json` by @lumirlumir in
#296
### 🔄 Continuous Integrations
* ci(sync-server): add permissions to read contents in `lint.yml` and
`test.yml` workflows by @lumirlumir in
#256
* ci(sync-server): add permissions to `pull-request.yml` and
`sync-client.yml` by @lumirlumir in
#257
* ci(*): add read permissions to `test-cross-platform.yml` by
@lumirlumir in
#258
* ci(*): update `llvm-build-bump-pr.yml` to add `permissions` and
disable `fail-fast` strategy by @lumirlumir in
#264
* ci(*): update `llvm-build-bump-pr.yml` to enhance permissions and add
build provenance attestations by @lumirlumir in
#265
* ci(*): create `release.yml` by @lumirlumir in
#281
### 📝 Documentation
* docs(*): delete maintainability badge from `README.md` by @lumirlumir
in #287
### ⬆️ Dependency Updates
* chore(deps-dev): bump typescript from 5.7.3 to 5.8.2 by @dependabot in
#252
* chore(deps-dev): bump prettier from 3.5.2 to 3.5.3 by @dependabot in
#253
* chore(deps-dev): bump @types/node from 22.13.5 to 22.13.8 by
@dependabot in
#251
* chore(deps-dev): bump lerna from 8.2.0 to 8.2.1 by @dependabot in
#254
* chore(deps-dev): bump @types/node from 22.13.8 to 22.13.9 by
@dependabot in
#255
* chore(deps-dev): bump @types/node from 22.13.9 to 22.13.10 by
@dependabot in
#261
* chore(deps-dev): bump eslint from 9.21.0 to 9.22.0 by @dependabot in
#262
* chore(deps): bump axios from 1.7.7 to 1.8.2 in the npm_and_yarn group
across 1 directory by @dependabot in
#263
* chore(deps-dev): bump @babel/core from 7.26.9 to 7.26.10 in the babel
group across 1 directory by @dependabot in
#268
* chore(deps-dev): bump textlint from 14.4.2 to 14.5.0 by @dependabot in
#270
* chore(deps-dev): bump vitepress-plugin-group-icons from 1.3.6 to 1.3.7
by @dependabot in
#269
* chore(deps-dev): bump eslint-config-bananass from 0.0.5 to 0.0.6 in
the bananass group across 1 directory by @dependabot in
#273
* chore(deps-dev): bump lint-staged from 15.4.3 to 15.5.0 by @dependabot
in #274
* chore(deps): bump shx from 0.3.4 to 0.4.0 by @dependabot in
#276
* chore(deps-dev): bump vitepress-plugin-group-icons from 1.3.7 to 1.3.8
by @dependabot in
#282
* chore(deps-dev): bump textlint-rule-allowed-uris from 1.0.8 to 1.0.9
by @dependabot in
#283
* chore(deps-dev): bump eslint from 9.22.0 to 9.23.0 by @dependabot in
#289
* chore(deps-dev): bump @types/node from 22.13.10 to 22.13.11 by
@dependabot in
#288
* chore(deps-dev): bump @babel/cli from 7.26.4 to 7.27.0 in the babel
group across 1 directory by @dependabot in
#291
* chore(deps-dev): bump @types/node from 22.13.11 to 22.13.13 by
@dependabot in
#290
* chore(deps-dev): bump @types/node from 22.13.13 to 22.13.14 by
@dependabot in
#292
* chore(deps-dev): bump textlint from 14.5.0 to 14.6.0 by @dependabot in
#294
* chore(deps-dev): bump @types/node from 22.13.14 to 22.13.17 by
@dependabot in
#295


**Full Changelog**:
v1.3.2...v1.3.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ scope: website Auto-generated label based on Conventional Commits specification for GitHub release notes 🏷️ type: chore Auto-generated label based on Conventional Commits specification for GitHub release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy