-
Notifications
You must be signed in to change notification settings - Fork 138
Add mariadb-cluster helm chart #1275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mariadb-cluster helm chart #1275
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks a lot for the initiative on this. Planning to release and document this as part of 0.39.0
.
Will following up with some adaptations to accomodate this in our CI and release process.
Is it still WIP? Happy to merge if it's not.
Well, I'm content with the initial version, so removing WIP. I have not done much of manual e2e testing though to be honest :) |
I'm happy enough with the automation you've built. Manual e2e testing will be conducted at the end of the release, planning to automate this at some point covering Helm installation. Will hold the merge until manual e2e testing is performed, since the chart will be automatically released after merging to mariadb-operator/.github/workflows/helm.yml Line 111 in 8671ab5
|
This will be included in 25.08.0 after I make the adaptations mentioned above. |
Hi team Thank you for inviting me to share feedback! I think it would be valuable to include a backup system, even in the first version of the Helm chart. Backups are critical for production use, and having even a basic option (e.g., scheduled backups to S3 or local PVC) would greatly help users adopt the chart safely from the start. Happy to discuss this further or help implement it if needed! Thanks again for your hard work on this project. If you want, I can also help you: |
@Amir-Ghojavand FYI we have supported |
no i mean backup for the helm chart not the crd of pbc |
7991585
to
6abfd67
Compare
@Amir-Ghojavand I've added backups templating with the corresponding test. Backup is a secondary resource like db/user/grant, so we will not impose it by default. Yet, a consumer will be able to configure it if need be. @mmontes11 I don't remember saying it, but I kinda intend to leave Chart.yaml (at least versions lol) and helm-docs stuff to you so you could polish it up to your liking and vision. |
Sure thing, will take care of the CI related stuff before the release. Will also add support for |
6abfd67
to
b9b75c7
Compare
The initial version of mariadb-cluster helm chart will be able to template:
Other resources might be included via prs in the future.
closes: #1273