[BREAKING CHANGE, Replication] Convert SyncBinlog to integer #1324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mmontes11 I think unit test workflow should be updated after recent changes. It passes only because of |
|
Hey @hedgieinsocks ! Thanks for flagging this. Indeed, there were some regressions in our end. Please rebase with main! |
1e7f881 to
dbc5743
Compare
mmontes11
requested changes
Jul 14, 2025
There was a problem hiding this comment.
Hey @hedgieinsocks ! Thanks for raising this.
Makes sense to me, left a couple of suggestions.
This will be listed as breaking change in the following release, as indicated in the PR description.
mmontes11
requested changes
Jul 14, 2025
a80ce30 to
09895e2
Compare
mmontes11
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed that my custom
sync_binlog=1000value from.spec.myCnfis not applied. It turned out the operator enforces either1or0. I think we should convert it to integer to allow proper configuration for those who want it.P.S. I believe this will require a special mention in the release notes so those who set it to
falsecould update their manifests.BREAKING CHANGE:
syncBinlogis now a*intinstead of a*bool, allowing to indicate the number of events after which the binlog is flushed to disk (see MariaDB docs.). Follow these steps for migrating:syncBinlog=true, setsyncBinlog=1syncBinlog=false, setsyncBinlog=0<number>of events, setsyncBinlog=<number>