FIX: re-jigger deprecation of rcParams using machinery in __init__ #10379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49bfe9d to
8549a5b
Compare
|
Alternative to #10378 sorry, I did not see that one existed! I think this one is a bit better as it cleans out all of the internal usage. |
|
No problem. I was just hacking. Glad you have a proper solution. |
QuLogic
approved these changes
Feb 5, 2018
jklymak
requested changes
Feb 5, 2018
| @@ -83,16 +83,16 @@ | |||
| if QT_API is None: | |||
| # No ETS environment or incompatible so use rcParams. | |||
| if rcParams['backend'] == 'Qt5Agg': | |||
| QT_API = rcParams['backend.qt5'] | |||
| QT_API = QT_API_PYQT5 | |||
There was a problem hiding this comment.
OK, but this does't just deprecate the rcparam, it now ignores it, right? Is that what you wanted? Feel free to clear if so, but putting a red x so its noted..
There was a problem hiding this comment.
Yes, but the rc deprecation tools do not have a gentler option
jklymak
approved these changes
Feb 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This suppresses the warnings in the test suite and removes
PR Checklist