Correctly display error when running setup.py test. #10837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We display an error if someone tries to run setup.py test (saying that one should run tests.py instead), but that doesn't get displayed if test.local_freetype is set in setup.cfg -- because the test command considers that equivalent to passing a (non-existent) local_freetype option to it, and fails first during argument parsing. As a solution, display the error in the constructor of the command instead.
timhoffm
approved these changes
Mar 19, 2018
dopplershift
approved these changes
Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We display an error if someone tries to run setup.py test (saying that
one should run tests.py instead), but that doesn't get displayed if
test.local_freetype is set in setup.cfg -- because the test command
considers that equivalent to passing a (non-existent) local_freetype
option to it, and fails first during argument parsing.
As a solution, display the error in the constructor of the command
instead.
Closes #8874.
PR Summary
PR Checklist