Unbreak formlayout for image edits. #12142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of master, the qt editor is broken when editing an axes that contains an image throws an error when clicking OK. This is because `self.data` needs to be modified *in-place* in FormWidget.setup, as FormWidget.get later checks some explicit types in there. This means, as a side note, that passing a tuple instead of a list to generate a QComboBox is broken (one can test that by modifying the example at the bottom of the module -- the results are different depending on whether 'list2' is a list or a tuple) but that's something we can deal with some other day...
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 17, 2018
tacaswell
added a commit
that referenced
this pull request
Sep 17, 2018
…142-on-v3.0.x Backport PR #12142 on branch v3.0.x (Unbreak formlayout for image edits.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of master, the qt editor is broken when editing an axes that contains
an image throws an error when clicking OK. This is because
self.dataneeds to be modified in-place in FormWidget.setup, as FormWidget.get
later checks some explicit types in there.
This means, as a side note, that passing a tuple instead of a list to
generate a QComboBox is broken (one can test that by modifying the
example at the bottom of the module -- the results are different
depending on whether 'list2' is a list or a tuple) but that's something
we can deal with some other day...
Partial revert of #11684 (well, I naively assumed that the base code was
correct...).
PR Summary
PR Checklist