V22x py38 compat #15448
Merged
V22x py38 compat #15448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[MRG] Use exact types for Py_BuildValue.
FIX: Correctly handle fallout of defining PY_SSIZE_T_CLEAN on Windows.
MNT: account for cpython deprecations The conflicts were due to other changes in the #includes in the affected files.
These were fixed the on the master branch as part of bigger PRs or in different ways that are not worth backporting
timhoffm
approved these changes
Oct 20, 2019
dstansby
approved these changes
Oct 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This backports several PRs to v2.2.x so it has many fewer warnings under py38