Shorter Path import in setupext. #16871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Mar 23, 2020
setupext.py
Outdated
| shutil.rmtree(str(pathlib.Path(src_path, "objs")), | ||
| ignore_errors=True) | ||
| else: # compilation on windows | ||
| shutil.rmtree(str(Path(src_path, "objs")), ignore_errors=True) |
There was a problem hiding this comment.
Suggested change
| shutil.rmtree(str(Path(src_path, "objs")), ignore_errors=True) | |
| shutil.rmtree(Path(src_path, "objs"), ignore_errors=True) |
as of Python 3.6 rmtree supports path-like objects.
Now that there's no `class Path` in setupext anymore, we can just do `from pathlib import Path`.
65b80e8 to
ef79317
Compare
timhoffm
approved these changes
Mar 23, 2020
QuLogic
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that there's no
class Pathin setupext anymore, we can just dofrom pathlib import Path.Small followup to #14442.
PR Summary
PR Checklist