Use ticklabels([]) instead of ticklabels('') #20632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Technically not a doc-only change because I also updated the tests. |
9137f20 to
5604fcc
Compare
story645
approved these changes
Jul 12, 2021
| @@ -68,8 +68,8 @@ def doall(): | |||
| plt.gca().set_ylim(0., 1.) | |||
| plt.gca().set_title("Matplotlib's math rendering engine", | |||
| color=mpl_grey_rvb, fontsize=14, weight='bold') | |||
| plt.gca().set_xticklabels("", visible=False) | |||
| plt.gca().set_yticklabels("", visible=False) | |||
There was a problem hiding this comment.
What is visible=False doing here?/is it okay that it's dropped?
There was a problem hiding this comment.
It sets all of the 0 created ticklabels to invisible 🙃 , i.e. does nothing.
The string variant is not supported according to the docstring. It's only working by accident.
5604fcc to
e0ddd9b
Compare
|
Self-merged based on the positive review. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The string variant is not supported according to the docstring. It's
only working by accident due to the list comprehension in
matplotlib/lib/matplotlib/axis.py
Line 1705 in 30cbdf7