Skip to content

Clean up test_chunksize_fails() #23420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 13, 2022
Merged

Clean up test_chunksize_fails() #23420

merged 3 commits into from
Jul 13, 2022

Conversation

timhoffm
Copy link
Member

PR Summary

Follow up to #23413.

  • Add a note why test_chunksize_fails() covers multiple test scenarios
  • Don't use path.Path if we have Path already imported
  • Reorder commands to make the function more understandable.

@dstansby dstansby added this to the v3.6.0 milestone Jul 13, 2022
@dstansby dstansby merged commit 37ccdca into matplotlib:main Jul 13, 2022
@timhoffm timhoffm deleted the test-cunksize branch July 19, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@timhoffm @QuLogic @dstansby
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy