Skip to content

Add support for auto scaling in LineCollection #29228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

kimmc6008
Copy link

@kimmc6008 kimmc6008 commented Dec 4, 2024

PR summary

  • This PR is to address [Bug]: Missing axes limits auto-scaling support for LineCollection #29219, which addresses the missing auto-scaling support for LineCollection objects.
  • The lack of this feature requires users to manually call ax.autoscale() when adding a LineCollection to an Axes.
  • The PR adds the autoscale inside Axes.add_collection() function to ensure that the scaling is done automatically, without having to call ax.autoscale()

With the change, the following code:

from matplotlib.collections import LineCollection

lc = LineCollection([[(x, x ** 2) for x in range(5)]])
ax = plt.gca()
ax.add_collection(lc)
plt.show()

Successfully creates:
image

PR checklist

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@QuLogic
Copy link
Member

QuLogic commented Aug 2, 2025

Thank you for your PR, and sorry it did not get much interaction. Unfortunately, this has been fixed by #29958 already, so it will not be needed. We hope this does not discourage you from future contributions, if you so wish.

@QuLogic QuLogic closed this Aug 2, 2025
@github-project-automation github-project-automation bot moved this from Needs review to Waiting for author in First Time Contributors Aug 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting for author
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy