Skip to content

Backport PR #30327 on branch v3.10.x (FIX Update Axes limits from Axes.add_collection(... autolim=True)) #30351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion lib/matplotlib/axes/_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -2373,7 +2373,17 @@ def add_collection(self, collection, autolim=True):
# the call so that self.dataLim will update its own minpos.
# This ensures that log scales see the correct minimum.
points = np.concatenate([points, [datalim.minpos]])
self.update_datalim(points)
# only update the dataLim for x/y if the collection uses transData
# in this direction.
x_is_data, y_is_data = (collection.get_transform()
.contains_branch_seperately(self.transData))
ox_is_data, oy_is_data = (collection.get_offset_transform()
.contains_branch_seperately(self.transData))
self.update_datalim(
points,
updatex=x_is_data or ox_is_data,
updatey=y_is_data or oy_is_data,
)

self.stale = True
return collection
Expand Down
23 changes: 15 additions & 8 deletions lib/matplotlib/tests/test_collections.py
Original file line number Diff line number Diff line change
Expand Up @@ -877,17 +877,24 @@ def test_collection_set_array():


def test_blended_collection_autolim():
a = [1, 2, 4]
height = .2
f, ax = plt.subplots()

xy_pairs = np.column_stack([np.repeat(a, 2), np.tile([0, height], len(a))])
line_segs = xy_pairs.reshape([len(a), 2, 2])
# sample data to give initial data limits
ax.plot([2, 3, 4], [0.4, 0.6, 0.5])
np.testing.assert_allclose((ax.dataLim.xmin, ax.dataLim.xmax), (2, 4))
data_ymin, data_ymax = ax.dataLim.ymin, ax.dataLim.ymax

f, ax = plt.subplots()
# LineCollection with vertical lines spanning the Axes vertical, using transAxes
x = [1, 2, 3, 4, 5]
vertical_lines = [np.array([[xi, 0], [xi, 1]]) for xi in x]
trans = mtransforms.blended_transform_factory(ax.transData, ax.transAxes)
ax.add_collection(LineCollection(line_segs, transform=trans))
ax.autoscale_view(scalex=True, scaley=False)
np.testing.assert_allclose(ax.get_xlim(), [1., 4.])
ax.add_collection(LineCollection(vertical_lines, transform=trans))

# check that the x data limits are updated to include the LineCollection
np.testing.assert_allclose((ax.dataLim.xmin, ax.dataLim.xmax), (1, 5))
# check that the y data limits are not updated (because they are not transData)
np.testing.assert_allclose((ax.dataLim.ymin, ax.dataLim.ymax),
(data_ymin, data_ymax))


def test_singleton_autolim():
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy