Support passing xticks/yticks when constructing secondary_axis. #30367
+48
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
reviewed
Jul 29, 2025
timhoffm
approved these changes
Jul 29, 2025
Sure, done. |
QuLogic
reviewed
Jul 31, 2025
Previously, passing xticks to a secondary_xaxis call, or similarly yticks to secondary_yaxis (see added test), would get silently ignored, because the set ticks would get overwritten in _set_scale (called by set_functions). Fix that by toggling the secax._ticks_set private flag, which already exists for that purpose in set_ticks. While at it, also simplify the implementation of set_ticks by relying on functools.wraps to copy the relevant signature.
QuLogic
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, passing xticks to a secondary_xaxis call, or similarly yticks to secondary_yaxis (see added test), would get silently ignored, because the set ticks would get overwritten in _set_scale (called by set_functions). Fix that by toggling the secax._ticks_set private flag, which already exists for that purpose in set_ticks.
While at it, also simplify the implementation of set_ticks by relying on functools.wraps to copy the relevant signature.
PR summary
PR checklist