TST: Make determinism test plots look less pathological #30374
Merged
+44
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, half the Axes are in a 2x2 grid, half are over the whole figure, and half are in a 1x6 grid (yes, that's more than 100% since they all overlap). Instead, place each optional section in a subfigure, and auto-size the figure based on how many sections there are.
story645
approved these changes
Jul 30, 2025
timhoffm
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Currently, half the Axes are in a 2x2 grid, half are over the whole figure, and half are in a 1x6 grid (yes, that's more than 100% since they all overlap).
Instead, place each optional section in a subfigure, and auto-size the figure based on how many sections there are. So instead of how it looks in #30360, it will look like:
I don't think this will do anything to fix the flakiness, but at least it will look reasonable when trying to compare the results.
PR checklist