Fix Line3DCollection with autolim=True for lines of different lengths #30423
+28
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using Line3DCollection with autolim=True, the code was trying to convert ragged arrays (lines with different numbers of points) directly to a numpy array, which would fail. This fix extracts coordinates separately to avoid the issue. Fixes matplotlib#30418
|
Please fix the linting errors. |
I fix it. |
|
This looks good, but should probably get a test so it doesn't break again. |
|
@QuLogic I have add the test. |
QuLogic
reviewed
Aug 20, 2025
There was a problem hiding this comment.
I don't think there's any need for a new file; this test can go in test_axes3d.py.
QuLogic
reviewed
Aug 20, 2025
| [(1, 0, 1), (2, 1, 2), (3, 2, 3), (4, 3, 4)] # 4 points | ||
| ] | ||
|
|
||
| # This should not raise an exception with the fix |
There was a problem hiding this comment.
"with the fix" won't make much sense in a few month.
Suggested change
| # This should not raise an exception with the fix | |
| # This should not raise an exception. |
Comment on lines
+2714
to
+2715
|
|
||
| plt.close(fig) |
There was a problem hiding this comment.
Not needed; all test figures are auto-closed.
Suggested change
| plt.close(fig) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
When using Line3DCollection with autolim=True, the code was trying to convert ragged arrays (lines with different numbers of points) directly to a numpy array, which would fail. This fix extracts coordinates separately to avoid the issue.
Fixes #30418