scale descent back #4838
Merged
scale descent back #4838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fix makes sense to me. Just as a sanity check, would the same problem exist for any of the other text drawing methods, or is magnification already dealt with? |
|
@WeatherGod From the SO question it looks like normal text is fine. If one of the mac based devs does not get to this soon I will merge it. |
|
and latex text? |
|
latex is handled through a different path, if it is also broken, this will not make it worse. Rather get small fixes in than hold up waiting to fix everything. |
tacaswell
added a commit
that referenced
this pull request
Jul 31, 2015
FIX: scale descent back on osx to fix text placement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug described here:
http://stackoverflow.com/questions/31690373/wrong-offset-when-using-math-mode-and-subscripts-in-matplotlib-and-osx
The bug was caused by scaling that was introduced to deal with Retina (double-resolution) screens; this caused the descent to be twice as large as it should be.