Update and fix tests for 3.7.0. #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of matplotlib version 3.7.0, the old Subplot class (an Axes subclass which stored info about its grid location and layout) was removed, and is now simply a reference to the Axes class which implements all the needed functionality. This patch fixes a single test that relied on the pre-3.7.0 behavior, by checking the matplotlib version before making assertions about Subplot and Axes not being the same class. Otherwise, all matplotview functionality works on v3.7.0 as expected, so a new release won't be made yet.