Skip to content

test: refactor tests using pytest.mark.parametrize #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 40 commits into from
Aug 24, 2022

Conversation

XuehaiPan
Copy link
Member

@XuehaiPan XuehaiPan commented Aug 8, 2022

Description

Describe your changes in detail.

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Closes #54

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • New environment (non-breaking change which adds 3rd-party environment)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format (required)
  • I have checked the code using make lint (required)
  • I have ensured make test pass. (required)

@XuehaiPan XuehaiPan force-pushed the fix-tests branch 2 times, most recently from 844324a to 38f352e Compare August 8, 2022 13:59
@XuehaiPan XuehaiPan added enhancement New feature or request jax Something JAX related bug Something isn't working labels Aug 8, 2022
@XuehaiPan XuehaiPan force-pushed the fix-tests branch 3 times, most recently from a31ff81 to 3244ed8 Compare August 10, 2022 11:08
@XuehaiPan XuehaiPan mentioned this pull request Aug 10, 2022
14 tasks
@XuehaiPan XuehaiPan force-pushed the fix-tests branch 3 times, most recently from 1212787 to b50f82f Compare August 11, 2022 07:51
@XuehaiPan XuehaiPan removed the jax Something JAX related label Aug 22, 2022
@XuehaiPan XuehaiPan merged commit 5dd8606 into metaopt:main Aug 24, 2022
@XuehaiPan XuehaiPan deleted the fix-tests branch August 24, 2022 12:59
@Benjamin-eecs Benjamin-eecs added this to the 0.5.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Align RMSProp optimizer with the PyTorch implementation
3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy