tests/cpydiff: Test for PEP487 __init_subclass__. #16786
+96
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #16786 +/- ##
=======================================
Coverage 98.44% 98.44%
=======================================
Files 171 171
Lines 22192 22208 +16
=======================================
+ Hits 21847 21863 +16
Misses 345 345 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
43df2ca to
c9ce19c
Compare
Signed-off-by: Anson Mansfield <amansfield@mantaro.com>
c9ce19c to
bfc173a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change documents and verifies the current absence of
__init_subclass__functionality, in anticipation of a possible future PEP487 'metaclasses lite' patch.The main
core_class_initsubclass.pytest verifies if the method is automatically called, while the other three verify other orthogonal properties it should have: if the method is an implicit classmethod; if micropython supplies the base case for the usual recursive function body the PEP encourages; and if kwargs inheritance parameters work correctly.Testing
I've verified that these tests fail as expected, correctly detecting the feature's absence.
Trade-offs and Alternatives
Some of the tests include code that regularizes across other unrelated differences between CPython and Micropython; but the complexity of this isn't large and it should be easy to verify that they wouldn't ever cause the tests to spuriously pass or fail.