extmod/vfs: Return mount table from no-args mount call. #16939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code size report: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #16939 +/- ##
=======================================
Coverage 98.54% 98.54%
=======================================
Files 169 169
Lines 21878 21887 +9
=======================================
+ Hits 21559 21568 +9
Misses 319 319 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dpgeorge
approved these changes
Mar 27, 2025
Signed-off-by: Anson Mansfield <amansfield@mantaro.com>
This extends the existing `vfs.mount()` function to accept zero arguments, in which case it returns a list of tuples of mounted filesystem objects and their mount location. Signed-off-by: Anson Mansfield <amansfield@mantaro.com>
Signed-off-by: Anson Mansfield <amansfield@mantaro.com>
Signed-off-by: Anson Mansfield <amansfield@mantaro.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a more minimal version of #16849, that overloads
vfs.mountto output the current vfs mount table when called with no arguments.Testing
This PR includes full automated tests; I have verified that these tests pass with the feature code and fail without it.
Trade-offs and Alternatives
In order to overload
vfs.mountto accept a zero-argument call, it's necessary to change the two existing arguments from fixed positional arguments into dynamic positional arguments handled bymp_arg_parse_all.I've re-defined them as required nameless arguments in the table for now so that their current positional-only behavior doesn't change:
This avoids introducing new QSTRs for the argument names
fsobjandmount_pointand avoids committing to those specific argument names as a visible part of the API (i.e.mount(fsobj=..., mount_point=...)remains an error). This may be a design decision worth revisiting (perhaps along with the argument names themselves).