tests/run-tests.py: Use TEST_TIMEOUT as timeout for bare-metal tests. #17697
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hmaerki FYI. This should fix both octoprobe/testbed_micropython#37 and octoprobe/testbed_micropython#40 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #17697 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 171 171
Lines 22210 22210
=======================================
Hits 21849 21849
Misses 361 361 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Code size report: |
|
stress_aes.py / pow3_intbig.py.out does not timeout anymore in https://reports.octoprobe.org/github_selfhosted_testrun_185/octoprobe_summary_report.html. Please merge this PR - thanks! |
Signed-off-by: Damien George <damien@micropython.org>
This parameter is already used for PC-based tests (eg unix and webassembly ports), and it makes sense for it to be used for bare-metal ports as well. That way the timeout is configurable for all targets. Because this increases the default timeout from 10s to 30s, this fixes some long-running tests that would previously fail due to a timeout such as `thread/stress_aes.py` on ESP32. Signed-off-by: Damien George <damien@micropython.org>
2a7e80e to
941b7e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This TEST_TIMEOUT parameter is already used for PC-based tests (eg unix and webassembly ports), and it makes sense for it to be used for bare-metal ports as well. That way the timeout is configurable for all targets.
Because this increases the default timeout from 10s to 30s, this fixes some long-running tests that would previously fail due to a timeout such as
thread/stress_aes.pyon ESP32.Testing
Tested with ESP32_GENERIC firmware. The
thread/stress_aes.pytest now passes (previously it would fail due to timeout).