embed: Fix alloca include for MinGW-w64 (Windows).
#17717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SiZiOUS <sizious@gmail.com>
cc677e3 to
95b22ac
Compare
stinos
reviewed
Jul 22, 2025
| #include <stdlib.h> | ||
| #elif defined(_WIN32) && (defined(__MINGW64_VERSION_MAJOR) || defined(__MINGW32_VERSION_MAJOR)) | ||
| // MinGW-w64; others Windows compilers probably need this too |
There was a problem hiding this comment.
Other compilers do need this, e.g. ports/windows/mpconfigport.h also has it for this reason. So I'd leave only the #elif defined(_WIN32) bit and mention explicitly it is needed for alloca().
There was a problem hiding this comment.
Thank you! Good catch. I’ll update this as suggested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When building the embedded port on MinGW-w64, I receive the following error:
MinGW-w64 (used on MSYS2) doesn't include
alloca.h, butalloca()is provided viamalloc.hinstead. This PR allows the build on this system.Probably this fix should be applied on other Windows build systems, but as I'm not sure and not really concerned, it fixes only MinGW-w64.
Note: A similar problem affected BSD in the past (see: #13360).
Testing
We are using MicroPython through KallistiOS, a library for developing on Sega Dreamcast, and more specifically a port in KallistiOS (kos-ports). Previously, it was impossible to compile this port with MinGW-w64 (the foundation of the DreamSDK environment), thanks to this fix, compilation is now possible and the problem is fixed.
See: KallistiOS/kos-ports#112