Skip to content

tools/ci.sh: Test building all natmod examples with all ARM-M archs. #17737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

tools/ci.sh: Test building all natmod examples with all ARM-M archs. #17737

wants to merge 3 commits into from
+31 −9

Conversation

dpgeorge
Copy link
Member

Summary

This adds a few more tests to CI, to build all natmod examples with all possible ARM-M architectures.

Testing

To be tested by CI.

@dpgeorge dpgeorge added the tools Relates to tools/ directory in source, or other tooling label Jul 22, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.41%. Comparing base (e993f53) to head (494f308).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #17737   +/-   ##
=======================================
  Coverage   98.41%   98.41%           
=======================================
  Files         171      171           
  Lines       22210    22210           
=======================================
  Hits        21857    21857           
  Misses        353      353

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions GitHub Actions
Copy link

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS
  qemu rv32:    +0 +0.000% VIRT_RV32

@dpgeorge dpgeorge force-pushed the tools-ci-build-all-arm-m-natmod branch 2 times, most recently from 82f526a to d8151ff Compare July 22, 2025 04:58
@dpgeorge
examples/natmod: Use LINK_RUNTIME=1 when building for armv6m.
6c4e804 
To get division helper functions, eg `__aeabi_uidiv`, `__aeabi_idiv` and
`__aeabi_uidivmod`.

Signed-off-by: Damien George <damien@micropython.org>
@dpgeorge dpgeorge force-pushed the tools-ci-build-all-arm-m-natmod branch from d8151ff to 6f0b4c3 Compare July 22, 2025 05:12
@dpgeorge
Copy link
Member Author

@agatti FYI

@agatti
Copy link
Contributor

agatti commented Jul 22, 2025

Nice! I wonder if it makes sense to also test those under QEMU.

If memory serves ARMv7 is a superset of ARMv6 so MPS2_AN385 should in theory be able to run some of the new targets unmodified. For hardfp targets, if the mps2-an500 QEMU machine definition allows to reuse most of the '385 implementation details this could be something interesting to look at.

Maybe I can give a shot at the hardfp targets for inclusion in the next release?

dpgeorge added 2 commits July 23, 2025 10:39
@dpgeorge
qemu/Makefile: Allow passing flags to test_natmod via RUN_TESTS_EXTRA.
f4e2eb5 
Signed-off-by: Damien George <damien@micropython.org>
@dpgeorge
tools/ci.sh: Test building all natmod examples with all ARM-M archs.
494f308 
And run both armv6m and armv7m under qemu.

Signed-off-by: Damien George <damien@micropython.org>
@dpgeorge dpgeorge force-pushed the tools-ci-build-all-arm-m-natmod branch from 6f0b4c3 to 494f308 Compare July 23, 2025 00:41
@dpgeorge
Copy link
Member Author

I wonder if it makes sense to also test those under QEMU.

Good idea. I've now added armv6m tests under QEMU. See what you think.

Maybe I can give a shot at the hardfp targets for inclusion in the next release?

Yes, that would be good. Shouldn't be too difficult.

@agatti
Copy link
Contributor

agatti commented Jul 23, 2025

Maybe I can give a shot at the hardfp targets for inclusion in the next release?
Yes, that would be good. Shouldn't be too difficult.

Indeed. Here's something working on the QEMU side: 6515cd0...agatti:micropython:qemu-armv7-machine - I haven't created a PR for it as I'll wait for this to get merged first. My plan was also to change the default Arm target from the '385 to the '500 but that may have some unintended consequences I'm not fully aware of.

@dpgeorge
Copy link
Member Author

That is pretty simple.

Well, let's wait for this PR to be merged, then we can take the next step there.

If you have any further comments about this one, let me know. Otherwise I think it's good to go in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tools Relates to tools/ directory in source, or other tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpgeorge @agatti
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy