tests/run-natmodtests.py: Automatically skip tests that are too large. #17738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows a similar change made for `run-tests.py` in commit 2291045. The change here uses the same logic to detect if a natmod test is too big for the target (eg overflows (I)RAM loading the native .mpy), by printing "START TEST" at the start of the test. Typical output is now something like this: ... pass extmod/random_basic.py pass extmod/random_extra_float.py pass extmod/random_extra.py SKIP extmod/random_seed_default.py LRGE extmod/re1.py SKIP extmod/re_debug.py pass extmod/re_error.py pass extmod/re_group.py pass extmod/re_groups.py ... and the tests that are too large are reported at the end, and written to the `_result.json` file. Signed-off-by: Damien George <damien@micropython.org>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #17738 +/- ##
=======================================
Coverage 98.41% 98.41%
=======================================
Files 171 171
Lines 22210 22210
=======================================
Hits 21857 21857
Misses 353 353 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This PR was triggered by Octoprobe failing a lot of natmod tests. Running this PR on Octoprobe, the results look very good: https://reports.octoprobe.org/github_selfhosted_testrun_190/octoprobe_summary_report.html @hmaerki FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This follows a similar change made for
run-tests.pyin PR #17361 / commit 2291045. The change here uses the same logic to detect if a natmod test is too big for the target (eg overflows (I)RAM loading the native .mpy), by printing "START TEST" at the start of the test, and checking if aMemoryErroris raised before that is printed (if so, the test is too large).Typical output from
run-natmodtests.pyis now something like this:and the tests that are too large are reported at the end, and written to the
_result.jsonfile (using the existing, commoncreate_test_report()function).Testing
Tested using the command:
with optional
-pto run on bare-metal.Tested on unix-standard
All existing tests still run and pass:
Tested on
ADAFRUIT_ITSYBITSY_M0_EXPRESSPrior to this PR:
With this PR:
Tested on ESP8266
With this PR the output is: