Skip to content

py/objint_longlong: Fix longlong interoperability with floats. #17740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

py/objint_longlong: Fix longlong interoperability with floats. #17740

wants to merge 1 commit into from
+41 −0

Conversation

yoctopuce
Copy link
Contributor

Summary

Current longlong implementation does not allow a float as RHS of mathematic operators, as it lacks the delegation code present in mpz. This was mentionned in in #16953 but postponed to a separate PR.

Testing

Test cases similar to int_big have been createt for int_64. The only test case which was not included is the complex test case, as small ports may not include complex support (eg. zephir).
The code has been tested on unix/longlong variant of development branch.

Trade-offs and Alternatives

This fixes a serious limitation of current longlong implementation, so I guess there isn't any tradeoff.

@yoctopuce
py/objint_longlong: Fix longlong interoperability with floats.
5b01728 
Current longlong implementation does not allow a float as
RHS of mathematic operators, as it lacks the delegation
code present in mpz.

Signed-off-by: Yoctopuce dev <dev@yoctopuce.com>
@codecov Codecov
Copy link

codecov bot commented Jul 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.41%. Comparing base (e993f53) to head (5b01728).
Report is 25 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #17740   +/-   ##
=======================================
  Coverage   98.41%   98.41%           
=======================================
  Files         171      171           
  Lines       22210    22210           
=======================================
  Hits        21857    21857           
  Misses        353      353

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions GitHub Actions
Copy link

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS
  qemu rv32:    +0 +0.000% VIRT_RV32

@yoctopuce
Copy link
Contributor Author

@dpgeorge @projectgus
The failing test is a false positive, so this code is ready for review.

@dpgeorge dpgeorge added the py-core Relates to py/ directory in source label Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
py-core Relates to py/ directory in source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoctopuce @dpgeorge
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy