stm32: Fix 12bit DAC issue on STM32H5. #17743
Open
+8
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The following code does not work with NUCLEO-H563ZI.
For STM32H5, DMA parameter should set:
Also, this PR modifies the definition of
DMA_CIRCULAR
for STM32H5 to prevent conflict with data width specification.Testing
Tested code above with NUCLEO-H563ZI.
Also, DAC with 8bit still works after applying this PR.
Trade-offs and Alternatives
The value of
DAC_CIRCULAR
is changed:from
>>> hex(DAC.CIRTUCLAR) '0x1'
to
>>> hex(DAC.CIRCULAR) '0x20000000'
Indeed, it won't be a problem because users do not need to be aware of value of
DAC.CIRCULAR
in most cases.