all: Go back to using default ruff quote style. #17744
Merged
+45
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cclauss FYI, did you have a reason for changing the quote style to "preserve"? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #17744 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 171 171
Lines 22238 22238
=======================================
Hits 21879 21879
Misses 359 359 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Code size report: |
|
Sorry if I made an error. The reason that I would use "preserve" is I say numerous quotes changes without it. I prefer the default setting so I am happy to see this PR. |
Commit dc2fcfc seems to have accidentally changed the ruff quote style to "preserve", instead of keeping it at the default which is "double". Put it back to the default and update relevant .py files with this rule. Signed-off-by: Damien George <damien@micropython.org>
3fb98b8 to
7729e80
Compare
cclauss
approved these changes
Jul 24, 2025
|
@cclauss thanks for the approval. I want to get this in now, because already it needs updating based on recent commits that had incorrect use of quotes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Commit dc2fcfc seems to have accidentally changed the ruff quote style to "preserve", instead of keeping it at the default which is "double".
Put it back to the default and update relevant .py files with this rule.
Testing
This is a just a Python formatting change, so shouldn't need any tests. But CI should anyway test the changes.