rp2/modmachine: Do not use deprecated XOSC_MHZ. #17746
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XOSC_MHZ is not defined if we use a custom XIN clock by defining PLL_SYS_REFDIV etc. calculated by vcocalc.py. Signed-off-by: Christian Lang <lang.chr86@gmail.com>
|
Code size report: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I replaced the crystal on a
W5500_EVB_PICOboard by a custom clock source which is not 12 MHz. Therefore I need to configure the SYS and USB PLL with custom dividers. The scriptvcocalc.pyis used to calculate the needed values and to generate the compiler definitions that need to be added to cmake.But when using such custom defines the
XOSC_MHZis not defined and the build fails.Testing
I tested this change while compiling for a
W5500_EVB_PICOboard with custom PLL settings as described above.